Skip to content

Update CI configuration to support multiple OS environments #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 14, 2025
Merged

Update CI configuration to support multiple OS environments #708

merged 12 commits into from
May 14, 2025
+14 −3

Conversation

DanielAvdar
Copy link
Contributor

@DanielAvdar DanielAvdar commented May 13, 2025 •
edited
Loading

add windows tests for ci, required for preventing and solving issues related to windows.

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@DanielAvdar DanielAvdar marked this pull request as ready for review May 13, 2025 18:30
@DanielAvdar
Copy link
Contributor Author

DanielAvdar commented May 13, 2025 •
edited
Loading

We need to reference issues related to Windows testing for better context. Relevant examples include:

#671: MCP Tool execution hangs indefinitely in stdio mode when calling external Python scripts
#575: RuntimeError during cleanup on Windows – no running event loop
#391: Proactor Windows warning on cleanup when using stdio_client
#526: MCP Server with Python on Claude Desktop Never Exits
#391: Proactor Windows warning on cleanup when using stdio_client
#433: SSE Connection Failure Described as "throw new Error('Not connected')"
#662: Error when calling MCP tool with arguments and tool name in live environment
#668: Will not work if multiple MCP inspector windows are open
Additionally, a review from the maintainers is needed. The required PR checks are targeting outdated test names (specific to Linux). Maintainers should update the required checks to reflect the new configuration.

@ihrpr

@ihrpr ihrpr added this to the HPR milestone May 13, 2025
ihrpr
ihrpr previously approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

I'll make changes in the config

Please can you rebase and I'll merge

@DanielAvdar DanielAvdar requested a review from ihrpr May 14, 2025 12:13
ihrpr
ihrpr approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@ihrpr ihrpr merged commit b8f7b02 into modelcontextprotocol:main May 14, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihrpr ihrpr ihrpr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
HPR
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielAvdar @ihrpr